Split Iter.Next(), RowToSQL, and callback into separate threads
#3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jycor
changed the title
jycor
changed the title
Iter.Next(), RowToSQL, and callback into separate threads
zachmu
approved these changes
Nov 19, 2025
| }) | ||
|
|
||
| // Drain rows from rowChan, convert to wire format, and send to resChan | ||
| var resChan = make(chan *sqltypes.Result, 4) |
Member
There was a problem hiding this comment.
Any particular reason for this buffer size being different than the row one
Contributor
Author
There was a problem hiding this comment.
This is a buffer of *sqltypes.Result, which hold rowBatch = 128 rows each, so 512/128 = 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on an optimization where we separate
iter.Next()andRowToSQL+callback()into two separate threads. Now,iter.Next(),RowToSQL, andcallback()all run in their own goroutines with corresponding buffered channels communicating between them.Additionally, this PR tidys up the
resultForDefaultIterandresultForValueItercode.Benchmarks: dolthub/dolt#10103 (comment)