Skip to content

Improve Dialect configuration #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2020
Merged

Improve Dialect configuration #51

merged 3 commits into from
May 11, 2020

Conversation

@backpaper0
Copy link
Member

@backpaper0 backpaper0 commented May 10, 2020 •
edited
Loading

The default value for Dialect has been improved.

Dialect is determined based on spring.datasource.url property, if all of the following conditions are true:

  • Missing Dialect bean
  • DomaProperties.getDialect return null
  • spring.datasource.url property exists

@backpaper0 backpaper0 force-pushed the improve-dialect-autoconfig branch from 9edcc6c to 7e94fdf Compare May 11, 2020 12:14
@backpaper0 backpaper0 merged commit 3706343 into master May 11, 2020
@backpaper0 backpaper0 deleted the improve-dialect-autoconfig branch May 11, 2020 12:19
@backpaper0 backpaper0 added this to the 1.4.0 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@backpaper0