Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon for .rst extension #116

Closed
valignatev opened this issue Jun 16, 2018 · 5 comments
Closed

No icon for .rst extension #116

valignatev opened this issue Jun 16, 2018 · 5 comments

Comments

@valignatev
Copy link

valignatev commented Jun 16, 2018

UPD check #116 (comment)

What do you think about using book icon for .rst files? .rst is ReStructuredText, similar to markdown.

Old issue text goes next:
Hi, thanks for a great package!
I noticed that README.rst and other-file-name.rst have a different file icon:
image

Is this intended? If it's a bug, maybe I can configure it with some workaround? I'll appreciate any tip.

P.S. I'm aware of #105, so I have font-lock+ installed, and for the most part icons are working great.

@wyuenho
Copy link
Collaborator

wyuenho commented Jun 20, 2018

Have you seen #106?

@valignatev
Copy link
Author

@wyuenho It's probably not related. PR makes icons work without need to use font-lock+ wihch I'm using, so PR shouldn't affect me. I think it becasue icon being choosed based on filename here instead of an extension. Check this:

("^readme" all-the-icons-octicon "book" :height 1.0 :v-adjust 0.0 :face all-the-icons-lcyan)

Now, when I jumped into code, I see that .rst just doesn't have its own icon. Probably I should rename the issue

@valignatev valignatev changed the title Different icons for files with same extension No icon for .rst extension Jun 20, 2018
@wyuenho
Copy link
Collaborator

wyuenho commented Jun 20, 2018

Then this isn't really a bug right? README is special-cased.

@valignatev
Copy link
Author

Yeah, now I understand it. Updated the issue text.

@wyuenho
Copy link
Collaborator

wyuenho commented Feb 15, 2019

ReStructuredText is one of the few OSS project that doesn't have its own logo, so the next best thing is a generic document icon, which is appropriate given its intended usage. Special-casing README also makes sense.

@wyuenho wyuenho closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants