-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong fonts being used when font-lock-mode
is enabled
#106
Conversation
`font-lock+` was removed, so `font-lock-ignore` no longer works.
Really fast patch. Great! |
This change works for me. |
@domtronn This is a perfectly good patch. Can it be merged? |
I did the modifications manually and it works. 😃
The line numbers of the patch matches with the current master version. So it shouldn't be a problem to merge. Please, can you merge this pull request so @melpa can have this patch? 🙏 Thanks! |
@ubolonton: can you rebase so it's easy to merge? |
Hi, What is the status of this bug? When is it planned to have an updated version of the package via MELPA? |
Still no progress on this PR. What about using a fork? |
This PR has almost been open for a year. Any chance of it going in soon? |
Somebody please fork this repo, change its name and submit PRs to all the packages on Melpa that's currently using all-the-icons to [your-new-repo]. I've emailed the author like 10 times, at once he promised to add me as a maintainer but it's been ages since then. |
Not sure why, but this patch does not work for me... inserting icons into a buffer without font-lock works, but turning on font-lock breaks all the icons. |
Aow, finally merged, thanks @wyuenho |
Still seeing this on master, fwiw. Investigating. Update: Partially fixed by updating the material design icon set as suggested in |
font-lock+
was removed, sofont-lock-ignore
no longer works.