Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

Bugfix url handling bug on logout [Web]#443

Merged
hyochan merged 4 commits into
hyochan:masterfrom
woosanggyu:feature/SangGyu
Aug 5, 2021
Merged

Bugfix url handling bug on logout [Web]#443
hyochan merged 4 commits into
hyochan:masterfrom
woosanggyu:feature/SangGyu

Conversation

@woosanggyu
Copy link
Copy Markdown
Contributor

@woosanggyu woosanggyu commented Aug 2, 2021

Specify project

web

Description

When connecting to the web, the URL does not change when logout of the settings page. And when you login again, you will be redirected to the settings page.

In order to handle url, the Navigation Container needs to give a proper linking prop, but AuthNavigatorOnly doesn't have a linking prop.

And signOutAsync does not initialize user information.

So, This solution initializes user information through User(null) in signOutAsync() of AuthProvider

Related Issues

change the url and user information initialize, when logout

Tests

web logout, and login again

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

[wehack2021]-[Cloud]

@woosanggyu woosanggyu changed the title Feature/sang gyu Bugfix/logout history[Web] Aug 2, 2021
@woosanggyu woosanggyu changed the title Bugfix/logout history[Web] Bugfix url handling bug on logout [Web] Aug 2, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 2, 2021

Codecov Report

Merging #443 (4e60216) into master (e960fac) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   62.68%   62.74%   +0.05%     
==========================================
  Files         108      108              
  Lines        2471     2472       +1     
  Branches      396      396              
==========================================
+ Hits         1549     1551       +2     
  Misses        794      794              
+ Partials      128      127       -1     
Impacted Files Coverage Δ
client/src/providers/AuthProvider.tsx 100.00% <100.00%> (ø)
client/src/components/pages/Settings.tsx 85.10% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d5080...4e60216. Read the comment docs.

@woosanggyu woosanggyu changed the title Bugfix url handling bug on logout [Web] Bugfix url handling bug on logout [Web] label:"🛠 bugfix" Aug 2, 2021
@woosanggyu woosanggyu changed the title Bugfix url handling bug on logout [Web] label:"🛠 bugfix" Bugfix url handling bug on logout [Web] "🛠 bugfix" Aug 2, 2021
@woosanggyu woosanggyu changed the title Bugfix url handling bug on logout [Web] "🛠 bugfix" Bugfix url handling bug on logout [Web] Aug 2, 2021
@hyochan hyochan added the 🛠 bugfix All kinds of bug fixes label Aug 3, 2021
Comment thread client/src/components/pages/Settings.tsx Outdated
remove the line break

Co-authored-by: Jeff Gu Kang <jeffgukang@gmail.com>
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you've finished your mission. Although there aren't many changes in lines of code, this is very valuable because there is the history we can go through in #429.

Usually, open-sourcing happens to end up in small changes even we start from the giant 😂

@hyochan hyochan merged commit 2c05e7f into hyochan:master Aug 5, 2021
@hyochan
Copy link
Copy Markdown
Owner

hyochan commented Aug 6, 2021

@all-contributors Please add @woosanggyu for code

@allcontributors
Copy link
Copy Markdown
Contributor

@hyochan

I've put up a pull request to add @woosanggyu! 🎉

imjlk pushed a commit to imjlk/hackatalk that referenced this pull request Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🛠 bugfix All kinds of bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants