This repository was archived by the owner on May 7, 2023. It is now read-only.
Bugfix url handling bug on logout [Web]#443
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 62.68% 62.74% +0.05%
==========================================
Files 108 108
Lines 2471 2472 +1
Branches 396 396
==========================================
+ Hits 1549 1551 +2
Misses 794 794
+ Partials 128 127 -1
Continue to review full report at Codecov.
|
JeffGuKang
reviewed
Aug 3, 2021
remove the line break Co-authored-by: Jeff Gu Kang <jeffgukang@gmail.com>
hyochan
approved these changes
Aug 5, 2021
Owner
hyochan
left a comment
There was a problem hiding this comment.
Great that you've finished your mission. Although there aren't many changes in lines of code, this is very valuable because there is the history we can go through in #429.
Usually, open-sourcing happens to end up in small changes even we start from the giant 😂
Owner
|
@all-contributors Please add @woosanggyu for code |
Contributor
|
I've put up a pull request to add @woosanggyu! 🎉 |
imjlk
pushed a commit
to imjlk/hackatalk
that referenced
this pull request
Aug 19, 2021
* Bugfix/logout history[Web]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify project
web
Description
When connecting to the web, the URL does not change when logout of the settings page. And when you login again, you will be redirected to the settings page.
In order to handle url, the Navigation Container needs to give a proper linking prop, but AuthNavigatorOnly doesn't have a linking prop.
And signOutAsync does not initialize user information.
So, This solution initializes user information through
User(null)insignOutAsync()ofAuthProviderRelated Issues
change the url and user information initialize, when logout
Tests
web logout, and login again
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn lint && yarn tscyarn testoryarn test -uif you need to update snapshot.[wehack2021]-[Cloud]