Skip to content
This repository was archived by the owner on May 7, 2023. It is now read-only.

feat: Add ability to leave channel in client#492

Merged
hyochan merged 3 commits into
hyochan:masterfrom
woosanggyu:feat/leaveChannel
Oct 3, 2021
Merged

feat: Add ability to leave channel in client#492
hyochan merged 3 commits into
hyochan:masterfrom
woosanggyu:feat/leaveChannel

Conversation

@woosanggyu
Copy link
Copy Markdown
Contributor

@woosanggyu woosanggyu commented Sep 27, 2021

Specify project

Client and Server

Description

To leave the chat room, Click the channel for a long time in the chat list and select 'YES'

Related Issues

N/A

Tests

leaveChannel.mov

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

[wehack2021] - [cloud]

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 27, 2021

Codecov Report

Merging #492 (c32d0bc) into master (a8ca199) will decrease coverage by 0.84%.
The diff coverage is 28.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   64.32%   63.47%   -0.85%     
==========================================
  Files         111      113       +2     
  Lines        2610     2667      +57     
  Branches      432      437       +5     
==========================================
+ Hits         1679     1693      +14     
- Misses        807      850      +43     
  Partials      124      124              
Impacted Files Coverage Δ
...omponents/navigations/MainStackNavigator/index.tsx 3.12% <ø> (ø)
client/src/components/uis/ChannelListItem.tsx 100.00% <ø> (ø)
client/src/relay/updaters.tsx 0.00% <0.00%> (ø)
server/src/models/Channel.ts 84.61% <ø> (ø)
server/src/services/ChannelService.ts 90.90% <ø> (ø)
...vigations/MainStackNavigator/LeaveChannelModal.tsx 25.71% <25.71%> (ø)
client/src/providers/LeaveChannelModalProvider.tsx 40.00% <40.00%> (ø)
client/src/components/pages/MainChannel.tsx 71.79% <50.00%> (-2.50%) ⬇️
server/src/resolvers/Channel/mutation.ts 86.04% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ca199...c32d0bc. Read the comment docs.

@woosanggyu
Copy link
Copy Markdown
Contributor Author

This "PR" was followed by https://github.com/dooboolab/hackatalk/pull/483

@hyochan hyochan added the 🎯 feature New feature label Sep 27, 2021
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update minor request 🙏

Comment thread client/src/components/navigations/MainStackNavigator/index.tsx
Comment thread client/src/components/navigations/MainStackNavigator/index.tsx Outdated
@woosanggyu woosanggyu requested a review from hyochan October 2, 2021 05:04
Copy link
Copy Markdown
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

I might have to change the design a bit tough

@hyochan hyochan merged commit c98f5c9 into hyochan:master Oct 3, 2021
@hyochan hyochan changed the title feat: Integrate leave channel resolver in client feat: Add ability to leave channel in client Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🎯 feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants