edit asp0028 /1 #34095
edit asp0028 /1 #34095
Conversation
aspnetcore/fundamentals/static-files/samples/9.x/StaticFilesSample/Program.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We have also changed the name to Consider using ListenAnyIP() instead of Listen(IPAddress.Any) (see PR notes)
can you please change the title \ description of the analyzer as well?
aspnetcore/diagnostics/asp0028.md
Outdated
| ## Cause | ||
|
|
||
| On the server machine that supports IPv6, listening to `Any`, rather than `IPv6Any` will either not work or be slower than necessary, because of the [underlying System types implementation](https://github.com/dotnet/runtime/issues/82404). | ||
| [IPv6Any](/dotnet/api/system.net.ipaddress.ipv6any) is preferred to [Any](/dotnet/api/system.net.ipaddress.any) because `Any` is less performant than `IPv6Any`. In some cases, `Any` may not work at all. `Any` has performance problems due to the [underlying System types implementation](https://github.com/dotnet/runtime/issues/82404). |
There was a problem hiding this comment.
phrasing has performance problems is not what I wanted to say - it raises a question of why not fix the System types then? I wanted to avoid this
There was a problem hiding this comment.
phrasing
has performance problemsis not what I wanted to say - it raises a question of why not fix the System types then? I wanted to avoid this
I've reverted to your wording with my wording. I don't see the difference between slower than necessary and less performant.
aspnetcore/diagnostics/asp0028.md
Outdated
| ## Cause | ||
|
|
||
| On the server machine that supports IPv6, listening to `Any`, rather than `IPv6Any` will either not work or be slower than necessary, because of the [underlying System types implementation](https://github.com/dotnet/runtime/issues/82404). | ||
| [IPv6Any](/dotnet/api/system.net.ipaddress.ipv6any) is preferred to [Any](/dotnet/api/system.net.ipaddress.any) because `Any` is less performant than `IPv6Any`. In some cases, `Any` may not work at all. `Any` has performance problems due to the [underlying System types implementation](https://github.com/dotnet/runtime/issues/82404). |
There was a problem hiding this comment.
lets also include the info about server machine supporting IPv6 - it is the case where the analyzer should be applied. Its necessary to have this information
|
@Rick-Anderson ... I opened a PR for it, but it's best if you fix it here ... ... throws a build warning. I'll close the PR that I opened. |
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
… into asp026/ra/1
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
| author: deaglegross | ||
| monikerRange: '>= aspnetcore-10.0' | ||
| ms.author: deaglegross | ||
| ms.author: dmkorolev |
Fixes #34090
Internal previews