Skip to content

Adding support for naming a container when using CreateContainer #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2014
Merged

Adding support for naming a container when using CreateContainer #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4549b7
Adding support for naming a container when using CreateContainer
jgarverick Oct 3, 2014
2b3ca06
Code fixes for PR #7
jgarverick Oct 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Docker.DotNet/ContainerOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,24 @@ public async Task<ContainerResponse> InspectContainerAsync(string id)

public async Task<CreateContainerResponse> CreateContainerAsync(CreateContainerParameters parameters)
{
IQueryString qs = null;

if (parameters == null)
{
throw new ArgumentNullException("parameters");
}

if (!string.IsNullOrEmpty(parameters.ContainerName)) {
qs = new QueryString<CreateContainerParameters>(parameters);
}

string path = "containers/create";
JsonRequestContent<Config> data = null;
if (parameters.Config != null)
{
data = new JsonRequestContent<Config>(parameters.Config, this.Client.JsonSerializer);
}
DockerApiResponse response = await this.Client.MakeRequestAsync(new[] {NoSuchContainerHandler}, HttpMethod.Post, path, null, data);
DockerApiResponse response = await this.Client.MakeRequestAsync(new[] {NoSuchContainerHandler}, HttpMethod.Post, path, qs, data);
return this.Client.JsonSerializer.DeserializeObject<CreateContainerResponse>(response.Body);
}

Expand Down
3 changes: 3 additions & 0 deletions Docker.DotNet/Models/CreateContainerParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ public class CreateContainerParameters
{
public Config Config { get; set; }

[QueryStringParameter("name", false)]
public string ContainerName { get; set; }

public CreateContainerParameters()
{
}
Expand Down