Skip to content

Conversation

@AndriySvyryd
Copy link
Member

No description provided.

@AndriySvyryd AndriySvyryd requested a review from a team October 7, 2024 22:32
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndriySvyryd what's the user-facing breaking change here?

@AndriySvyryd
Copy link
Member Author

@AndriySvyryd what's the user-facing breaking change here?

The new dependencies "break" the functionality provided by the shared framework, so now users don't get the automatic patching and size-savings. This is mostly for awareness, as it's very easy to miss otherwise.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new dependencies "break" the functionality provided by the shared framework, so now users don't get the automatic patching and size-savings.

I'm not sure these constitute breaking changes, but if you feel strongly about it am OK to merge.

@AndriySvyryd AndriySvyryd merged commit e27774b into main Oct 10, 2024
4 checks passed
@AndriySvyryd AndriySvyryd deleted the SharedFx branch October 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants