Skip to content

Avoid exception when ClientRealmName is null and IsolateRealmsConsistently is off #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

Avoid exception when ClientRealmName is null and IsolateRealmsConsistently is off #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2261812
Add compatibility flag check before throwing exception on missing Cli…
MaximeKjaer Sep 23, 2025
6a83b99
Add unit test
MaximeKjaer Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Kerberos.NET/Entities/Krb/KrbKdcRep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,11 @@ out MessageType messageType
if (request.Compatibility.HasFlag(KerberosCompatibilityFlags.NormalizeRealmsUppercase))
{
request.RealmName = request.RealmName?.ToUpperInvariant();
request.ClientRealmName = request.ClientRealmName?.ToUpperInvariant() ?? throw new InvalidOperationException("Unknown client realm name");

if (request.Compatibility.HasFlag(KerberosCompatibilityFlags.IsolateRealmsConsistently))
{
request.ClientRealmName = request.ClientRealmName?.ToUpperInvariant() ?? throw new InvalidOperationException("Unknown client realm name");
}
}

authz ??= GenerateAuthorizationData(request);
Expand Down
36 changes: 36 additions & 0 deletions Tests/Tests.Kerberos.NET/Messages/KrbKdcRepTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,42 @@ public void CreateServiceTicket_NullPrincipal()
});
}

[TestMethod]
public void CreateServiceTicket_NullClientRealmName()
{
var key = KrbEncryptionKey.Generate(EncryptionType.AES128_CTS_HMAC_SHA1_96).AsKey();

// This should not throw, as ClientRealmName is allowed to be null if CompatibilityFlags.IsolateRealmsConsistently is not set
var tgsRep = KrbKdcRep.GenerateServiceTicket<KrbTgsRep>(new ServiceTicketRequest
{
EncryptedPartKey = key,
ServicePrincipal = new FakeKerberosPrincipal("blah@blah.com"),
ServicePrincipalKey = key,
Principal = new FakeKerberosPrincipal("blah@blah2.com"),
RealmName = "blah.com",
ClientRealmName = null,
Compatibility = KerberosCompatibilityFlags.NormalizeRealmsUppercase,
});
}

[TestMethod]
[ExpectedException(typeof(InvalidOperationException))]
public void CreateServiceTicket_NullClientRealmName_IsolateRealmsConsistently()
{
var key = KrbEncryptionKey.Generate(EncryptionType.AES128_CTS_HMAC_SHA1_96).AsKey();

var tgsRep = KrbKdcRep.GenerateServiceTicket<KrbTgsRep>(new ServiceTicketRequest
{
EncryptedPartKey = key,
ServicePrincipal = new FakeKerberosPrincipal("blah@blah.com"),
ServicePrincipalKey = key,
Principal = new FakeKerberosPrincipal("blah@blah2.com"),
RealmName = "blah.com",
ClientRealmName = null,
Compatibility = KerberosCompatibilityFlags.NormalizeRealmsUppercase | KerberosCompatibilityFlags.IsolateRealmsConsistently,
});
}

[TestMethod]
public void CreateServiceTicket()
{
Expand Down