Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Description

This PR enables the new PR pipelines for all desired branches.

I still need to figure out how to configure GitHub to require these PR pipelines to pass as branch checks. They don't currently appear in the GitHub UI as checks I can select.

Copilot AI review requested due to automatic review settings November 12, 2025 12:10
@paulmedynski paulmedynski changed the title Enable new PR pipelines [DRAFT] Enable new PR pipelines Nov 12, 2025
Copilot finished reviewing on behalf of paulmedynski November 12, 2025 12:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the new PR validation pipelines for all target branches by removing temporary CI debugging restrictions. The pipelines will now trigger PR validation builds for pull requests targeting dev/*, feat/*, and main branches instead of being limited to the dev/paul/ci-debug* test branches.

  • Removed temporary branch restrictions from PR pipeline configurations
  • Enabled PR validation for production branch patterns (dev/*, feat/*, main)
  • Applied changes consistently across both project-reference and package-reference pipelines

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/pipelines/sqlclient-pr-project-ref-pipeline.yml Updated PR trigger branches from test-only pattern to production patterns
eng/pipelines/sqlclient-pr-package-ref-pipeline.yml Updated PR trigger branches from test-only pattern to production patterns

- Updated all path specs to include all files/directories that affect builds.
- Improved documentation.
- Reduced Debug test job timeout from 180 to 110 minutes.
Copilot AI review requested due to automatic review settings November 12, 2025 17:29
Copilot finished reviewing on behalf of paulmedynski November 12, 2025 17:30
@paulmedynski paulmedynski marked this pull request as ready for review November 12, 2025 17:31
@paulmedynski paulmedynski requested a review from a team as a code owner November 12, 2025 17:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

@paulmedynski paulmedynski changed the title [DRAFT] Enable new PR pipelines Enable new PR pipelines Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (ac757fa) to head (0123bf1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3759      +/-   ##
==========================================
+ Coverage   76.47%   76.61%   +0.13%     
==========================================
  Files         273      273              
  Lines       44180    44180              
==========================================
+ Hits        33787    33848      +61     
+ Misses      10393    10332      -61     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 76.69% <ø> (+0.19%) ⬆️
netfx 76.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mdaigle
mdaigle previously approved these changes Nov 13, 2025
Copilot AI review requested due to automatic review settings November 13, 2025 18:17
Copilot finished reviewing on behalf of paulmedynski November 13, 2025 18:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

@paulmedynski paulmedynski merged commit 7be3371 into main Nov 14, 2025
515 checks passed
@paulmedynski paulmedynski deleted the dev/paul/pr-pipelines branch November 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants