Document exceptions SqlConnection constructors might throw #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
added
the
Area\Documentation
cheenamalhotra
approved these changes
Feb 26, 2020
Member
|
Not yet, I will follow up to get CI setup for documentation testing. |
cheenamalhotra
pushed a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doc issue against S.D.SqlClient exists for M.D.SqlClient, too:
dotnet/dotnet-api-docs#3468
Creating this PR so we don't miss it. Do we have documentation on how to validate doc edits? (I'm not 100% sure this change is syntactically correct.)