Scripts #772
Merged
Scripts #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Calling methods other than 'forward' 2. Compiling Python scripts containing functions.
This was
linked to
issues
Oct 3, 2022
|
@kaiidams -- this is in response to your recent issues. If you have some time, please take a look at it. |
tarekgh
reviewed
Oct 3, 2022
tarekgh
reviewed
Oct 3, 2022
tarekgh
previously approved these changes
Oct 3, 2022
kaiidams
previously approved these changes
Oct 4, 2022
NiklasGustafsson
dismissed stale reviews from kaiidams and tarekgh
via
b244ff0
NiklasGustafsson
requested review from
kaiidams and
tarekgh
and removed request for
kaiidams
|
@tarekgh, @kaiidams -- I need to bother you with a re-review. I've added limited support for additional types in TorchScript, and that code needs some checking. Specifically, it's the passing of TensorOrScalar to and from native code, as well as the processing of arguments and return values on either side. |
tarekgh
reviewed
Oct 4, 2022
tarekgh
reviewed
Oct 4, 2022
tarekgh
reviewed
Oct 4, 2022
tarekgh
reviewed
Oct 4, 2022
tarekgh
previously approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #770 and #765.