Make HttpClient static in JdkInstaller (#291)

Copilot · jonathanpeppers · web-flow · commit 6a6de1f24572 · 2026-03-03T06:20:51.000-08:00
Context: https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines#recommended-use * Make HttpClient static in JdkInstaller per Microsoft guidelines Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
diff --git a/src/Xamarin.Android.Tools.AndroidSdk/JdkInstaller.cs b/src/Xamarin.Android.Tools.AndroidSdk/JdkInstaller.cs
@@ -30,15 +30,15 @@ public class JdkInstaller : IDisposable
 
 		static readonly IProgress<JdkInstallProgress> NullProgress = new Progress<JdkInstallProgress> ();
 
-		readonly HttpClient httpClient = new();
+		static readonly HttpClient httpClient = new();
 		readonly Action<TraceLevel, string> logger;
 
 		public JdkInstaller (Action<TraceLevel, string>? logger = null)
 		{
 			this.logger = logger ?? AndroidSdkInfo.DefaultConsoleLogger;
 		}
 
-		public void Dispose () => httpClient.Dispose ();
+		public void Dispose () { }
 
 		/// <summary>Discovers available Microsoft OpenJDK versions for the current platform.</summary>
 		public async Task<IReadOnlyList<JdkVersionInfo>> DiscoverAsync (CancellationToken cancellationToken = default)

Original file line number	Diff line number	Diff line change
`@@ -30,15 +30,15 @@ public class JdkInstaller : IDisposable`
`30`	`30`
`31`	`31`	`static readonly IProgress<JdkInstallProgress> NullProgress = new Progress<JdkInstallProgress> ();`
`32`	`32`
`33`		`- readonly HttpClient httpClient = new();`
	`33`	`+ static readonly HttpClient httpClient = new();`
`34`	`34`	`readonly Action<TraceLevel, string> logger;`
`35`	`35`
`36`	`36`	`public JdkInstaller (Action<TraceLevel, string>? logger = null)`
`37`	`37`	`{`
`38`	`38`	`this.logger = logger ?? AndroidSdkInfo.DefaultConsoleLogger;`
`39`	`39`	`}`
`40`	`40`
`41`		`- public void Dispose () => httpClient.Dispose ();`
	`41`	`+ public void Dispose () { }`
`42`	`42`
`43`	`43`	`/// <summary>Discovers available Microsoft OpenJDK versions for the current platform.</summary>`
`44`	`44`	`public async Task<IReadOnlyList<JdkVersionInfo>> DiscoverAsync (CancellationToken cancellationToken = default)`