Skip to content

Conversation

@jonathanpeppers
Copy link
Member

Context: dotnet/android@80559b5

We are already using the 28.x Android NDK, so we should allow it here.

I also updated a unit test that was outdated.

Context: dotnet/android@80559b5

We are already using the 28.x Android NDK, so we should allow it here.

I also updated a unit test that was outdated.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the maximum compatible Android NDK major version from 26 to 28, aligning the code with the actual NDK version already in use. The change ensures that the system can properly recognize and work with NDK 28.x versions.

Key changes:

  • Updated MaximumCompatibleNDKMajorVersion constant from 26 to 28 in production code
  • Enhanced unit test to include NDK versions 26-28 and verify correct version selection logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Xamarin.Android.Tools.AndroidSdk/Sdks/AndroidSdkBase.cs Updated the maximum compatible NDK version constant from 26 to 28
tests/Xamarin.Android.Tools.AndroidSdk-Tests/AndroidSdkInfoTests.cs Updated test constant and added NDK versions 26-28 to test array; changed expected version logic to use second-to-last element

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jonathanpeppers jonathanpeppers merged commit 8722663 into main Oct 15, 2025
1 check passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/ndk28 branch October 15, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants