-
Notifications
You must be signed in to change notification settings - Fork 564
Enable more tests to run on all 3 runtimes, part 4 #10591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+279
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4099e75 to
fe7b9f0
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fe7b9f0 to
d442b7d
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
d442b7d to
ba7b37c
Compare
jonathanpeppers
approved these changes
Nov 20, 2025
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore MAUI Integration lane, and the test:
Build_JLO_Change
Exceeded expected time of 4500ms, actual 5125.963ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request expands the test coverage in
BindingBuildTest.csto run binding and application tests across multiple Android runtimes by parameterizing tests with theAndroidRuntimeenum. It also updates test setup logic to properly configure projects for each runtime and ensures unsupported configurations are skipped.Test parameterization and runtime support:
All major test methods in
BindingBuildTest.csnow accept anAndroidRuntime runtimeparameter (using[Values]or[TestCaseSource]), allowing tests to run against all supported runtimes.Test projects are now configured per-runtime by setting
IsReleaseaccording to the runtime (NativeAOT uses Release), and callingSetRuntime(runtime)on each project.Test data generation improvements:
ClassParseOptionsarray is replaced with aGet_ClassParseOptions()method, which dynamically generates test cases for eachAndroidRuntimevalue, ensuring all relevant runtime combinations are tested.Test execution control:
IgnoreUnsupportedConfiguration(runtime, release: isRelease)at the start, and skip execution if the configuration is not supported. This prevents failures on unsupported runtime/build type combinations.Test path consistency and cleanup:
TestNameandPath.Combineto generate unique temporary directories for builds, improving test isolation and consistency.These changes make the test suite more robust, comprehensive, and maintainable by ensuring all supported Android runtimes are covered and by improving test configuration and isolation.