[marshal methods] Make AndroidEnvironmentInternal.UnhandledException … #10607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Can we write some Mono.Cecil code to make this public at build time? So, no one can use it at C# compile time?
This would happen in the marshal methods MSBuild steps, if they run.
src/Mono.Android.Runtime/Android.Runtime/AndroidEnvironmentInternal.cs
Outdated
Show resolved
Hide resolved
…public Fixes: #10602 Context: 8bc7a3e This is in the category of "how the hell has it worked before?", as every time the `AndroidEnvironmentInternal.UnhandledException` method living in `Mono.Android.Runtime.dll` would be called, the runtime would respond with a method not accessible exception, rightly so as both the type and the method were internal and visible only to `Mono.Android.dll`. I guess we haven't had many unhandled exceptions in marshal method wrappers over the years? This PR fixes the problem by making both the type and the method public. This is the simplest way to fix the issue.
The rewrite changes visibility of the `Android.Runtime.AndroidEnvironmentInternal` type from `internal` to `public` after all the linking and marshal method processing is done.
grendello
force-pushed
the
dev/grendel/mm-unhandledexception
branch
from
a2771cd to
826cf5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…public
Fixes: #10602
Context: 8bc7a3e
This is in the category of "how the hell has it worked before?", as every time the
AndroidEnvironmentInternal.UnhandledExceptionmethod living inMono.Android.Runtime.dllwould be called, the runtime would respond with a method not accessible exception, rightly so as both the type and the method were internal and visible only toMono.Android.dll.I guess we haven't had many unhandled exceptions in marshal method wrappers over the years?
This PR fixes the problem by making both the type and the method public. This is the simplest way to fix the issue.