Skip to content

[build] Relax 16k native library alignment checks #10608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

[build] Relax 16k native library alignment checks #10608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Xamarin.Android.Build.Tasks/Utilities/ELFHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@ static void AssertValidLibraryAlignment (TaskLoggingHelper log, uint pageSize, s
throw new InvalidOperationException ($"Internal error: {segment} is not Segment<ulong>");
}

// TODO: what happens if the library is aligned at, say, 64k while 16k is required? Should we erorr out?
// We will need more info about that, have to wait till Google formally announce the requirement.
// At this moment the script https://developer.android.com/guide/practices/page-sizes#test they
// provide suggests it's a strict requirement, so we test for equality below.
if (segment64.Alignment == pageSize) {
// Android allows alignment higher than the page size, as long as it's a power of two. See:
//
// https://android.googlesource.com/platform//system/extras/+/3c784e9fd9f4e3f8e363a023939567c41c19d634%5E%21/#F0
//
if (segment64.Alignment >= pageSize && (segment64.Alignment % 2 == 0)) {
Copy link
Member

@jonathanpeppers jonathanpeppers Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for a number like 4 or 8 (kb) to come in as the page size? And that wouldn't be 16kb?

Copy link
Member

@jonathanpeppers jonathanpeppers Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(discussed in meeting) as-is might be fine, actually checking >= 16kb makes it more complicated for 32-bit

continue;
}
log.LogDebugMessage ($" expected segment alignment of 0x{pageSize:x}, found 0x{segment64.Alignment:x}");
log.LogDebugMessage ($" expected segment alignment of at least 0x{pageSize:x} and a power of two, found 0x{segment64.Alignment:x}");

(string packageId, string packageVersion, string originalFile) = GetNugetPackageInfo ();
log.LogCodedWarning ("XA0141", Properties.Resources.XA0141, packageId, packageVersion, originalFile, Path.GetFileName (path));
Expand Down
Loading