Skip to content

Conversation

@jonathanpeppers
Copy link
Member

I also improved things so it's easier to bump this going forward:

  • I added KnownPackages.XamarinForms_LatestStable, so tests won't
    need to change going forward.
  • Xamarin.Forms.Performance.Integration now uses
    <PackageReference/>. The netstandard library was already.

I also removed some missing Icon files from the forms project. These
did not even exist.

XamarinFormsPCL_2_3_4_231 was also unused, so I removed it.

I also improved things so it's easier to bump this going forward:

* I added `KnownPackages.XamarinForms_LatestStable`, so tests won't
  need to change going forward.
* `Xamarin.Forms.Performance.Integration` now uses
  `<PackageReference/>`. The netstandard library was already.

I also removed some missing `Icon` files from the forms project. These
did not even exist.

`XamarinFormsPCL_2_3_4_231` was also unused, so I removed it.

I updated APK sizes, which I think is smaller because of:

xamarin/Xamarin.Forms#5941
@jonathanpeppers
Copy link
Member Author

When switching the XF integration app to <PackageReference/>, I'm hitting some issues building:

The nuget command failed with exit code(1) and error(Errors in F:\A\xamarin-v000006-1\_work\2\s\tests\Xamarin.Forms-Performance-Integration\Droid\Xamarin.Forms.Performance.Integration.Droid.csproj
    Project Xamarin.Forms.Performance.Integration is not compatible with monoandroid10.0 (MonoAndroid,Version=v10.0). Project Xamarin.Forms.Performance.Integration supports: netstandard2.0 (.NETStandard,Version=v2.0)
    One or more projects are incompatible with MonoAndroid,Version=v10.0.)

This appears to be happening when running nuget restore Xamarin.Android-Tests.sln, when it has mixed packages.config and <PackageReference>.

I may hold off on this until we get #3995, or after we switch everything to short-form MSBuild projects.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant