Skip to content

Remove unnecessary CA2022 suppressions #15673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 8 commits into from
Apr 4, 2025
Merged

Remove unnecessary CA2022 suppressions #15673

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
98ccfed
Remove unnecessary CA2022 suppressions
Winniexu01 Mar 27, 2025
8623d72
Merge branch 'main' into CA2022
Winniexu01 Mar 28, 2025
0bc7cc0
Format code
Winniexu01 Mar 31, 2025
df33d97
Merge branch 'main' into CA2022
Winniexu01 Mar 31, 2025
fd37f37
Format extension method
Winniexu01 Mar 31, 2025
460ff21
Merge branch 'main' into CA2022
Winniexu01 Apr 1, 2025
2c24ae7
Merge branch 'main' into CA2022
Winniexu01 Apr 2, 2025
45cd2c9
Merge branch 'main' into CA2022
Winniexu01 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/SignCheck/Microsoft.SignCheck/Verification/LZMAUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,35 @@ public static void Decompress(string sourceFile, string destinationFile)
byte[] properties = new byte[5];
byte[] fileLengthBytes = new byte[8];

#pragma warning disable CA2022 // Avoid inexact read
inFile.Read(properties, 0, 5);
inFile.Read(fileLengthBytes, 0, 8);
#pragma warning restore CA2022
ReadExactly(inFile, properties, 0, 5);
ReadExactly(inFile, fileLengthBytes, 0, 8);

long fileLength = BitConverter.ToInt64(fileLengthBytes, 0);
decoder.SetDecoderProperties(properties);

decoder.Code(inFile, outFile, inFile.Length, fileLength, progress: null);
}
}

#if NET
private static void ReadExactly(FileStream stream, byte[] buffer, int offset, int count)
{
stream.ReadExactly(buffer, offset, count);
}
#else
private static void ReadExactly(FileStream stream, byte[] buffer, int offset, int count)
{
while (count > 0)
{
int read = stream.Read(buffer, offset, count);
if (read <= 0)
{
throw new EndOfStreamException();
}
offset += read;
count -= read;
}
}
#endif
}
}
Loading