Add support for passing arguments to containers#1121
Merged
BrennanConroy merged 3 commits intomainfrom Nov 30, 2023
Merged
Conversation
ghost
added
the
area-app-model
Contributor
|
Filed #1122 for follow-up for dashboard to light up the information. |
davidfowl
reviewed
Nov 29, 2023
karolz-ms
requested changes
Nov 30, 2023
Contributor
karolz-ms
left a comment
karolz-ms
left a comment
There was a problem hiding this comment.
Thanks Brennan. I think we need a couple of changes, but overall looks good.
karolz-ms
approved these changes
Nov 30, 2023
Contributor
|
@BrennanConroy we should also consider making this a callback so that we can get allocated endpoints from other resources. |
ericmutta
added a commit
to ericmutta/aspire
that referenced
this pull request
Dec 8, 2023
The wording in the XML docs is based on my cursory review of [issue 177](microsoft#177) and [PR 1121](microsoft#1121). I should add that I only started reviewing Aspire a few hours ago, so apologies if the XML docs aren't accurate - I just figured the best way to get started contributing is to jump right in (CC: @danmoseley). #Fixes microsoft#1294
mitchdenny
added a commit
that referenced
this pull request
Dec 12, 2023
* Add XML Docs for WithArgs() The wording in the XML docs is based on my cursory review of [issue 177](#177) and [PR 1121](#1121). I should add that I only started reviewing Aspire a few hours ago, so apologies if the XML docs aren't accurate - I just figured the best way to get started contributing is to jump right in (CC: @danmoseley). #Fixes #1294 * Update ContainerResourceBuilderExtensions.cs --------- Co-authored-by: Mitch Denny <midenn@microsoft.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
The wording in the XML docs is based on my cursory review of [issue 177](#177) and [PR 1121](#1121). I should add that I only started reviewing Aspire a few hours ago, so apologies if the XML docs aren't accurate - I just figured the best way to get started contributing is to jump right in (CC: @danmoseley). #Fixes #1294
DamianEdwards
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Add XML Docs for WithArgs() The wording in the XML docs is based on my cursory review of [issue 177](#177) and [PR 1121](#1121). I should add that I only started reviewing Aspire a few hours ago, so apologies if the XML docs aren't accurate - I just figured the best way to get started contributing is to jump right in (CC: @danmoseley). #Fixes #1294 * Update ContainerResourceBuilderExtensions.cs --------- Co-authored-by: Eric Mutta <eric.mutta@gmail.com> Co-authored-by: Mitch Denny <midenn@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #177
Questions:
params string[]? I'm worried about arbitrarily splitting the args by space in case something like'Program Files'needs to be in a single list entry.WriteContainer