Make Copy tooltip text configurable#1127
Merged
tlmii merged 2 commits intomicrosoft:mainfrom Nov 30, 2023
Merged
Conversation
tlmii
requested review from
JamesNK,
adamint,
drewnoakes,
leslierichardson95 and
smitpatel
JamesNK
approved these changes
Nov 30, 2023
…ameDisplay.razor Co-authored-by: James Newton-King <james@newtonking.com>
smitpatel
approved these changes
Nov 30, 2023
andrevlins
pushed a commit
to andrevlins/aspire
that referenced
this pull request
Dec 3, 2023
* Make Copy tooltip text configurable * Update src/Aspire.Dashboard/Components/ResourcesGridColumns/ResourceNameDisplay.razor Co-authored-by: James Newton-King <james@newtonking.com> --------- Co-authored-by: James Newton-King <james@newtonking.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up during the UX board meeting today. It was suggested that the tooltip here should indicate what it is going to copy, since there are two distinct pieces of information in the cell where the copy button lives. So this text makes the Pre/Post copy text configurable and then changes it for that one usage, leaving it the default in all other uses.