Skip to content

Password escaping for MySql, Postgres, and SQL Server#1134

Merged
mitchdenny merged 3 commits intomainfrom
sql-password-escaping
Nov 30, 2023
Merged

Password escaping for MySql, Postgres, and SQL Server#1134
mitchdenny merged 3 commits intomainfrom
sql-password-escaping

Conversation

@mitchdenny
Copy link
Copy Markdown
Member

@mitchdenny mitchdenny commented Nov 30, 2023

Fixes #1131

Will need similar approaches for other connection strings, but the rules are slightly different for say MySQL or Postgres.

Turns out that Postgres, MySql and SQL Server appear to support the same escaping mechanism.

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 30, 2023
@mitchdenny mitchdenny changed the title SQL Server password escaping. Password escaping for MySql, Postgres, and SQL Server Nov 30, 2023
@mitchdenny mitchdenny merged commit 3365f9e into main Nov 30, 2023
@mitchdenny mitchdenny deleted the sql-password-escaping branch November 30, 2023 04:35
andrevlins pushed a commit to andrevlins/aspire that referenced this pull request Dec 3, 2023
* SQL Server password escaping.

* Add MySql escaping.

* Add tests for postgres.
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password for SQL Server container is not quoted in connection string

2 participants