Password escaping for MySql, Postgres, and SQL Server#1134
Merged
mitchdenny merged 3 commits intomainfrom Nov 30, 2023
Merged
Conversation
danmoseley
approved these changes
Nov 30, 2023
andrevlins
pushed a commit
to andrevlins/aspire
that referenced
this pull request
Dec 3, 2023
* SQL Server password escaping. * Add MySql escaping. * Add tests for postgres.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1131
Will need similar approaches for other connection strings,
but the rules are slightly different for say MySQL or Postgres.Turns out that Postgres, MySql and SQL Server appear to support the same escaping mechanism.