Use ValueStopWatch#1148
Merged
ReubenBond merged 1 commit intomicrosoft:mainfrom Nov 30, 2023
Merged
Conversation
ghost
added
the
Member
|
In some cases, using |
eerhardt
reviewed
Nov 30, 2023
|
|
||
| namespace Microsoft.Extensions.Internal; | ||
|
|
||
| internal struct ValueStopwatch |
Member
There was a problem hiding this comment.
internal readonly struct ValueStopwatch
Where did you take this code from? It looks to be a copy from https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Http/src/ValueStopwatch.cs, but doesn't have this change in it.
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Yeah I got it from the aspnetcore repo and removed the #ifs since this project is target .NET 8.0. Should I make the struct readonly as well?
andrevlins
pushed a commit
to andrevlins/aspire
that referenced
this pull request
Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.