Skip to content

Clean up default values in API comments#1155

Merged
sebastienros merged 3 commits intomainfrom
sebros/defaultvaluesdoc
Dec 2, 2023
Merged

Clean up default values in API comments#1155
sebastienros merged 3 commits intomainfrom
sebros/defaultvaluesdoc

Conversation

@sebastienros
Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 30, 2023
@DamianEdwards
Copy link
Copy Markdown
Member

Does it change how it's shown visually in VS, etc.? If so, can you add a screenshot?

@sebastienros
Copy link
Copy Markdown
Contributor Author

Before

image

After

image

That's how @gewarren showed us how to write these in dotnet/extensions.
Also interesting read: https://github.com/dotnet/dotnet-api-docs/wiki

@gewarren
Copy link
Copy Markdown

gewarren commented Dec 1, 2023

Does it change how it's shown visually in VS, etc.? If so, can you add a screenshot?

It will also populate the Value section of the online docs.

@sebastienros sebastienros enabled auto-merge (squash) December 1, 2023 23:34
@sebastienros sebastienros merged commit c7e7c35 into main Dec 2, 2023
@sebastienros sebastienros deleted the sebros/defaultvaluesdoc branch December 2, 2023 00:01
andrevlins pushed a commit to andrevlins/aspire that referenced this pull request Dec 3, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants