Conversation
Contributor
davidfowl
commented
Dec 1, 2023
davidfowl
commented
- Make AddDapr idempotent so that calling it multiple times noops.
- Use IOptions for top level DaprOptions
- Calling WithDaprSidecar calls AddDapr
- Make AddDapr idempotent so that calling it multiple times noops. - Use IOptions for top level DaprOptions - Calling WithDaprSidecar calls AddDapr
ghost
added
the
area-app-model
philliphoff
reviewed
Dec 1, 2023
| context.Writer.WriteStartObject("daprComponent"); | ||
|
|
||
| context.Writer.TryWriteString("localPath", context.GetManifestRelativePath(resource.Options?.LocalPath)); | ||
| if (resource.Options?.LocalPath is { } localPath) |
Member
There was a problem hiding this comment.
Curious as to the need for this test. GetManifestRelativePath() returns null if given null, and TryWriteString() will omit the entry if given null.
Contributor
Author
There was a problem hiding this comment.
Its possible my VS was going crazy. I was getting null warnings for this.
Member
There was a problem hiding this comment.
I (at least attempted) to add the null analyzer attributes to make that work (which it did on my machine, but who knows).
philliphoff
approved these changes
Dec 1, 2023
eerhardt
approved these changes
Dec 1, 2023
andrevlins
pushed a commit
to andrevlins/aspire
that referenced
this pull request
Dec 3, 2023
- Make AddDapr idempotent so that calling it multiple times noops. - Use IOptions for top level DaprOptions - Calling WithDaprSidecar calls AddDapr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.