App model rework around resource types and connection string emission…#1270
Merged
davidfowl merged 1 commit intorelease/8.0-preview2from Dec 8, 2023
Merged
App model rework around resource types and connection string emission…#1270davidfowl merged 1 commit intorelease/8.0-preview2from
davidfowl merged 1 commit intorelease/8.0-preview2from
Conversation
… for containers (#1165) * Abstract resources and templated connection strings. * Add abstract redis for testing. * Moved MySql to input request model. * Postgres implementation. * Update PostgresBuilderExtensions.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Migrate RabbitMQ to new model. * Migrate SQL to new model. * Test case updates. * Update mongo resource to the new model. * Update manfiests. * Update template. --------- Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
davidfowl
approved these changes
Dec 7, 2023
drewnoakes
approved these changes
Dec 8, 2023
Member
drewnoakes
left a comment
There was a problem hiding this comment.
Approving on the basis that this code was already reviewed on main and merged there, and this is just a backport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #1165