Skip to content

remove --pre-release flag from extension official build #12897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2025
Merged

remove --pre-release flag from extension official build #12897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
224b445
remove --pre-release flag
adamint Nov 11, 2025
4591d02
Merge branch 'main' into dev/adamint/fix-release-as-prerelease
adamint Nov 11, 2025
4e0bbcd
bump version
adamint Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/Extension.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<MakeDir Directories="$(ArtifactsPackagesDir)\vscode" />

<!-- Package extension -->
<Exec Command="vsce package --pre-release --out $(ArtifactsPackagesDir)\vscode\aspire-vscode-$(_ExtractedVersion).vsix"
<Exec Command="vsce package --out $(ArtifactsPackagesDir)\vscode\aspire-vscode-$(_ExtractedVersion).vsix"
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --pre-release flag is being removed from the official build, but .github/workflows/tests.yml line 194 still packages the extension with --pre-release flag during extension tests. This inconsistency could lead to differences between test artifacts and production builds. Consider updating the test workflow to match this change for consistency.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@adamint adamint Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That distinction is intentional.

IgnoreStandardErrorWarningFormat="true"
WorkingDirectory="$(ExtensionSrcDir)" />
</Target>
Expand Down
2 changes: 1 addition & 1 deletion extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Aspire",
"description": "%extension.description%",
"publisher": "microsoft-aspire",
"version": "1.0.0",
"version": "1.0.1",
"aiKey": "0c6ae279ed8443289764825290e4f9e2-1a736e7c-1324-4338-be46-fc2a58ae4d14-7255",
"icon": "dotnet-aspire-logo-128.png",
"license": "SEE LICENSE IN LICENSE.TXT",
Expand Down