Fix types that shouldn't derive from container resource. (#1337)#1338
Merged
davidfowl merged 1 commit intorelease/8.0-preview2from Dec 12, 2023
Merged
Fix types that shouldn't derive from container resource. (#1337)#1338davidfowl merged 1 commit intorelease/8.0-preview2from
davidfowl merged 1 commit intorelease/8.0-preview2from
Conversation
ghost
added
the
area-app-model
Member
|
@mitchdenny FWIW, you should now be able to just add a comment on the original PR like |
Member
Author
|
@joperezr Thanks! |
joperezr
approved these changes
Dec 11, 2023
DamianEdwards
approved these changes
Dec 11, 2023
Member
DamianEdwards
left a comment
DamianEdwards
left a comment
There was a problem hiding this comment.
I'd like this in preview.2 for sure, so we don't lead folks to treating these resources as containers and making customizations to them like volume mounts, etc. that won't be reflected in the manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1337
Microsoft Reviewers: Open in CodeFlow