[release/8.0-preview2] Add XML Docs for WithArgs()#1353
Merged
DamianEdwards merged 2 commits intorelease/8.0-preview2from Dec 13, 2023
Merged
[release/8.0-preview2] Add XML Docs for WithArgs()#1353DamianEdwards merged 2 commits intorelease/8.0-preview2from
DamianEdwards merged 2 commits intorelease/8.0-preview2from
Conversation
The wording in the XML docs is based on my cursory review of [issue 177](#177) and [PR 1121](#1121). I should add that I only started reviewing Aspire a few hours ago, so apologies if the XML docs aren't accurate - I just figured the best way to get started contributing is to jump right in (CC: @danmoseley). #Fixes #1294
ghost
added
the
area-codeflow
mitchdenny
approved these changes
Dec 12, 2023
sebastienros
approved these changes
Dec 12, 2023
joperezr
reviewed
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1308 to release/8.0-preview2
/cc @mitchdenny @ericmutta
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Microsoft Reviewers: Open in CodeFlow