[release/8.0-preview2] Reduce CPU while polling for console log changes#1369
Merged
DamianEdwards merged 1 commit intorelease/8.0-preview2from Dec 13, 2023
Merged
Conversation
The current implementation polls the file system for changes to stdout/stderr files on disk. This polling causes high CPU while logs are visible in the UI. To reduce the problem, we introduce a small sleep that happens only when we are caught up with the contents of the file. The delay of 100ms is forever in computer time (i.e. it's a low duty cycle activity) while also being very fast for a human's perception. Note that if logs start streaming in fast, we will not hit this sleep. It only occurs when we've read everything. If in the subsequent 100ms new logs arrive, they'll all be processed in the next iteration of the loop. Longer term we hope to have a console log streaming API from DCP for this.
ghost
added
the
area-codeflow
JamesNK
approved these changes
Dec 12, 2023
DamianEdwards
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1354 to release/8.0-preview2
/cc @drewnoakes
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.
Microsoft Reviewers: Open in CodeFlow