Add friendly error messages to health check failures#14072
Open
Add friendly error messages to health check failures#14072
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Health checks were displaying raw exception stack traces instead of actionable error messages. Dashboard users saw multi-line exception details like
System.Threading.Tasks.TaskCanceledException: The operation was canceled. ---> System.IO.IOException: Unable to read data from the transport connection...with no clear indication of what failed.The root cause was that the third-party
UriHealthCheckfromAspNetCore.HealthChecks.Urisreturns unhealthy results with exception information in the Description field rather than the Exception property. The initial implementation only wrapped results when an exception object was present, allowing most unhealthy results to pass through with raw stack traces.Changes
HTTP endpoint health checks (
ExternalServiceBuilderExtensions.cs):StaticUriHealthCheckand enhancedParameterUriHealthCheckto wrapUriHealthCheckfromAspNetCore.HealthChecks.UrisComponent health checks - Added descriptive error messages for 6 components:
Additional improvements from PR review feedback:
ParameterUriHealthCheckto create freshUriHealthCheckOptionsper invocation to avoid duplicate URI accumulationException objects remain attached to
HealthCheckResultfor detailed debugging when needed.Example
Before:
After:
or
Checklist
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.