Skip to content

Add a polling check for endpoints to workaround proxy 404 bug in dashboard#1427

Merged
davidfowl merged 15 commits intorelease/8.0-preview2from
smit/servicesarenotready
Dec 16, 2023
Merged

Add a polling check for endpoints to workaround proxy 404 bug in dashboard#1427
davidfowl merged 15 commits intorelease/8.0-preview2from
smit/servicesarenotready

Conversation

@danegsta
Copy link
Copy Markdown
Member

@danegsta danegsta commented Dec 16, 2023

Mitigates #1364 for preview2

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 16, 2023
Copy link
Copy Markdown
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@danegsta danegsta requested a review from karolz-ms December 16, 2023 01:29
@dbreshears dbreshears requested a review from JamesNK December 16, 2023 01:33
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Copy link
Copy Markdown

@kvenkatrajan kvenkatrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - thanks!

Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
Comment thread src/Aspire.Hosting/Dashboard/DashboardViewModelService.cs Outdated
@davidfowl davidfowl enabled auto-merge (squash) December 16, 2023 07:55
@davidfowl davidfowl merged commit 44f41d3 into release/8.0-preview2 Dec 16, 2023
@davidfowl davidfowl deleted the smit/servicesarenotready branch December 16, 2023 08:47
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 26, 2024
@github-actions github-actions Bot added area-dashboard and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants