Localization cleanup: remove unused keys, localize hardcoded strings#15112
Draft
adamint wants to merge 6 commits intorelease/13.2from
Draft
Localization cleanup: remove unused keys, localize hardcoded strings#15112adamint wants to merge 6 commits intorelease/13.2from
adamint wants to merge 6 commits intorelease/13.2from
Conversation
Dashboard: - Removed 11 unused resource keys across 6 .resx files - Localized hardcoded 'MCP Server' string in MainLayout.razor CLI: - Removed 35 unused resource keys across 16 .resx files - Localized ~60 hardcoded user-facing strings across 18 source files - Added corresponding resource entries to .resx and .Designer.cs files - Fixed misspelled UnxpectedCodePath -> UnexpectedCodePath Extension: - No changes needed (all 131 localized keys are in use)
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15112Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15112" |
- DCP server: 4 error messages (missing DCP prefix, unsupported launch config,
debug session not found, failed to start debug session)
- dotnet debugger: 2 error messages (run-api failures)
- do command: 1 input placeholder ('deploy')
…n-cleanup # Conflicts: # src/Aspire.Cli/Projects/GuestAppHostProject.cs # src/Aspire.Cli/Resources/ErrorStrings.resx # src/Aspire.Cli/Resources/NewCommandStrings.resx # src/Aspire.Cli/Resources/TemplatingStrings.Designer.cs # src/Aspire.Cli/Resources/TemplatingStrings.resx # src/Aspire.Cli/Templating/CliTemplateFactory.EmptyTemplate.cs # src/Aspire.Cli/Templating/CliTemplateFactory.TypeScriptStarterTemplate.cs
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22931846442 |
…atting - Restored ConsoleLogsPauseActive and ConsoleLogsPauseDetails to ConsoleLogs.resx - Fixed XML formatting in 6 resx files where key removal collapsed </data><data - Removed orphaned Designer.cs properties for correctly-removed keys - Updated XLF files for ConsoleLogs - Fixed trailing whitespace in CLI files
Member
|
Looks like this has gone out of date. Are you still planning to port the loc changes over for 13.2? |
This was referenced Mar 14, 2026
Member
|
Chatted with @adamint offline. We are going to hold off on this until 13.2.1 |
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comprehensive localization cleanup across the Aspire Dashboard, CLI, and VS Code extension:
UnxpectedCodePath→UnexpectedCodePath)Dashboard Changes
Removed 11 unused resource keys across 6 .resx files:
AIAssistant.resx:SidebarShrinkDialog,ChatRequestErrorRateLimitedConsoleLogs.resx:ConsoleLogsNoResourceSelected,ConsoleLogsPauseActive,ConsoleLogsPauseDetailsControlsStrings.resx:ViewLogsLink,ViewStructuredLogsTextDialogs.resx:SettingsExportAllButtonText,McpServerDialogOtherDescriptionResources.resx:ResourceDetailsViewConsoleLogsStructuredLogs.resx:StructuredLogsMinimumLogFilterLocalized 1 hardcoded string:
MainLayout.razor: Hardcoded "MCP Server" →Layout.MainLayoutMcpServerLinkCLI Changes
Removed 35 unused resource keys across 16 .resx files:
AddCommandStrings:UsePrereleasePackagesAgentCommandStrings:ConfigUpdatesSelectPrompt,SkipNoneDescriptionDoCommandStrings:GeneratingArtifactsErrorStrings:FailedToRetrieveCachedAllAspirePackages,SingleFileAppHostFeatureNotEnabledInitCommandStrings:CreatingAppHostProject,CreatingServiceDefaultsProject,AddingProjectsToSolutionInteractionServiceStrings:DirectLink,CodespacesLinkLogsCommandStrings:ResourceRequiredWithoutFollow,TailRequiresResourceMcpCommandStrings:InitCommand_AgentConfigurationSelectPrompt,InitCommand_AdditionalOptionsSelectPrompt,InitCommand_CreateAgentInstructionsPrompt,InitCommand_ConfigurePlaywrightPromptNewCommandStrings:UsePrereleaseTemplatesPublishCommandStrings:GeneratingArtifacts,InputPromptLoadingRootCommandStrings:FirstTimeUseWelcomeRunCommandStrings:ForceArgumentDescription,JsonArgumentDescription,WatchArgumentDescription,AgentConfigurationPrompt,AgentConfigurationYes,AgentConfigurationNo,AgentConfigurationMaybeLater,AgentConfigurationSelectPrompt,WaitingForAppHostToStart,IsolatedArgumentDescriptionStopCommandStrings:MultipleAppHostsRunningTelemetryCommandStrings:TraceIdArgumentDescriptionUpdateCommandStrings:UnxpectedCodePath(misspelled)Localized ~60 hardcoded user-facing strings across 18 source files:
ResourceCommandHelper.cs: 6 strings (command execution success/failure/cancel messages)StopCommand.cs: 2 strings (found running app host, sending stop signal)UpdateCommand.cs: 10 strings (self-update flow messages)InitCommand.cs: 9 strings (project creation failure/success messages)McpCallCommand.cs: 2 strings (JSON validation, tool call failure)McpToolsCommand.cs: 1 string (no resources with MCP tools)TelemetryTracesCommand.cs/TelemetrySpansCommand.cs: 1 string each (resource not found)GuestAppHostProject.cs: 5 strings (run/publish/dependency errors, SDK/package updates)SetupCommand.cs: 4 strings (bundle extraction messages)CliTemplateFactory.EmptyTemplate.cs: 3 strings (language/project creation messages)CliTemplateFactory.TypeScriptStarterTemplate.cs: 2 strings (project creation messages)CliDownloader.cs: 1 string (validating download)NuGetConfigPrompter.cs: 3 strings (NuGet config prompts)LanguageService.cs: 2 strings (language preference messages)RunningInstanceManager.cs: 1 string (stopping previous instance)SdkDumpCommand.cs: 5 strings (integration/package validation errors)SdkGenerateCommand.cs: 5 strings (SDK generation errors/results)ScaffoldingService.cs: 1 string (build failure)VS Code Extension Changes
Localized 7 hardcoded user-facing strings across 3 source files:
AspireDcpServer.ts: 4 DCP error messages (missing DCP prefix, unsupported launch config type, debug session not found, failed to start debug session)dotnet.ts: 2 error messages (dotnet run-api failure, unexpected response type)do.ts: 1 input placeholder ('deploy')Validation
Checklist