Clean up Aspire panel: context menus, loading state, welcome messages#15375
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15375Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15375" |
There was a problem hiding this comment.
Pull request overview
Improves the Aspire panel’s tree view UX by adding additional context-menu actions, introducing a loading welcome state, and refining welcome messaging based on view mode (workspace vs global).
Changes:
- Add context-menu copy actions (resource name, PID, apphost path) and introduce a dedicated PID tree item type.
- Add a loading state context (
aspire.loading) and update viewsWelcome conditions to show loading / mode-specific welcome messages. - Adjust handling of
aspire describe --followearly exit to prefer the standard “no running apphost” welcome over the CLI-not-supported banner in that case.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/src/views/AspireAppHostTreeProvider.ts | Adds PidItem and new copy commands for tree items. |
| extension/src/views/AppHostDataRepository.ts | Tracks/loading state and updates VS Code context keys for welcome rendering. |
| extension/src/loc/strings.ts | Adds a generic “copied to clipboard” localized string helper. |
| extension/src/extension.ts | Registers new commands and initializes the new loading context. |
| extension/package.nls.json | Adds/updates localized strings for welcome messages and command titles. |
| extension/package.json | Adds new commands and updates menus + viewsWelcome logic for loading/mode-specific welcomes. |
| extension/loc/xlf/aspire-vscode.xlf | Updates XLF localization entries for some (but not all) new/changed strings. |
You can also share your feedback on Copilot code review. Take the survey.
fbf6bc1 to
91c096f
Compare
|
Re-running the failed jobs in the CI workflow for this pull request because 3 jobs were identified as retry-safe transient failures in the CI run attempt.
|
Adds initial 'loading' screen, new context menus for resources, endpoints, apphost, and PID nodes. Consolidates previous 3 commits into one for clean rebase onto main.
91c096f to
dad7d06
Compare
…#15375) * Clean up Aspire panel: context menus, loading state, welcome messages Adds initial 'loading' screen, new context menus for resources, endpoints, apphost, and PID nodes. Consolidates previous 3 commits into one for clean rebase onto main. * remove unused strings * remove comands on resources node, update string
…#15375) * Clean up Aspire panel: context menus, loading state, welcome messages Adds initial 'loading' screen, new context menus for resources, endpoints, apphost, and PID nodes. Consolidates previous 3 commits into one for clean rebase onto main. * remove unused strings * remove comands on resources node, update string
) * Add right-click context menu on resource endpoint URLs (#15347) Add three context menu actions for endpoint URL tree items in the Running AppHosts tree view: - Copy URL to Clipboard - Open in External Browser - Open in Simple Browser Introduces EndpointUrlItem TreeItem subclass with contextValue 'endpointUrl' to enable context menu targeting, replacing the generic DetailItem for endpoint URLs. Fixes #15345 Co-authored-by: Mitch Denny <mitch@mitchdeny.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clean up Aspire panel: context menus, loading state, welcome messages (#15375) * Clean up Aspire panel: context menus, loading state, welcome messages Adds initial 'loading' screen, new context menus for resources, endpoints, apphost, and PID nodes. Consolidates previous 3 commits into one for clean rebase onto main. * remove unused strings * remove comands on resources node, update string * Add AppHost CodeLens and gutter decoration support (#15397) * Add CodeLens and gutter decoration support for AppHost resources * wip * remove status bar strings from branch * Add CodeLens, gutter decorations, and AppHost resource parsers for VS Code extension - Add CodeLens provider showing resource state, actions (start/stop/restart), and view logs - Add gutter decoration provider with colored status circles for resources - Add C# and JS/TS AppHost resource parsers with registry pattern - Add statementStartLine for multi-line fluent chain CodeLens positioning - Add comment-skipping logic so CodeLens appears below comments, above code - Extract shared resource state utilities and resource constants - Add enableCodeLens and enableGutterDecorations settings - Add comprehensive test coverage (parsers, CodeLens, resourceStateUtils) - Only match parent resources (Add* calls), not implicit child resources (With* calls) * Address Copilot review: conditional appHostPath, displayName preference, Unhealthy as error - Guard --apphost flag when appHostPath is falsy in CodeLens commands - Prefer displayName over name in two-pass resource matching - Classify Unhealthy health status as error (not warning) to align with tree view * bump extension version * update config json * Fix dashboard image in marketplace README and bump version to 1.0.6 (#15379) * Fix dashboard image URL: dotnet -> microsoft (#15466 partial) --------- Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: Mitch Denny <mitch@mitchdeny.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
General cleanup for panel, including requested changes from #15347.
Adds an initial 'loading' screen so that the initial message displayed in the panel is correct. "Searching for running apphosts..."
New resource node context menu:

New link node context menu:

New apphost (global mode only, because the data is not available via aspire describe) context menu:

New apphost pid/cli pid context menus:

Checklist