Merged
Conversation
ghost
added
the
area-integrations
Contributor
Author
|
/cc @andrevlins |
eerhardt
reviewed
Feb 14, 2024
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Same comment as SqlServer about sharing common code across EF components.
src/Components/Aspire.Oracle.EntityFrameworkCore/AspireOracleEFCoreExtensions.cs
Outdated
Show resolved
Hide resolved
tests/Aspire.Oracle.EntityFrameworkCore.Tests/ConformanceTests_Pooling.cs
Show resolved
Hide resolved
Contributor
Author
I'll do that when all PRs are merged #2233 |
Member
Why can't we do it on one of them - let's say SqlServer. Get that merged, and then update this one after that is merged? |
Contributor
Author
|
Because I find it easier this way. Independent PRs, and then one more to refactor when they are in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow