Fix dashboard running without resource server#2199
Merged
Conversation
drewnoakes
approved these changes
Feb 13, 2024
Member
drewnoakes
left a comment
drewnoakes
left a comment
There was a problem hiding this comment.
We should verify that CI is running these tests before merge.
JamesNK
force-pushed
the
jamesnk/dashboard-standalone
branch
from
f0fcfa0 to
ce8b1a9
Compare
Member
Author
|
|
This was referenced Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1556
Aspire.Dashboard.Components.Testsand test. I follows guidance from https://learn.microsoft.com/en-us/aspnet/core/blazor/test for setting up Blazor unit testing. This particular test could have been written by moving logic into a view model and then testing the view model, but that's overkill for a simple control.Microsoft Reviewers: Open in CodeFlow