Avoid adding non-HTTP URLs to ASPNETCORE_URLS during launch#2239
Merged
ReubenBond merged 2 commits intomainfrom Feb 15, 2024
Merged
Avoid adding non-HTTP URLs to ASPNETCORE_URLS during launch#2239ReubenBond merged 2 commits intomainfrom
ReubenBond merged 2 commits intomainfrom
Conversation
ghost
added
the
area-engineering-systems
Member
|
What's the difference between endpoints and services? I thought endpoints were always http/https and services contained other connection types. |
…albe set to ASPNETCORE_URLS during launch
ReubenBond
force-pushed
the
rebond/fix-non-http-uris-in-ASPNETCORE_URLS
branch
from
d7cd7a0 to
543b5d7
Compare
Member
Author
|
I don't see a service annotation in the app model, but there's one (well, one consumer, one producer) in the DCP model. I updated the PR to skip the endpoint if either:
|
Member
Endpoints cover all kinds of network endpoints, not just HTTP/HTTPS. |
mitchdenny
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all endpoint annotations are contributing to
ASPNETCORE_URLS. I believe we should not be adding "tcp://" endpoints there. This currently blows up Kestrel when trying to get Aspire to allocate ports for an Orleans silo, for example.There is precedent for the filtering added by this PR here: https://github.com/dotnet/aspire/blob/5f19c77227ccb5637960b07d8a7e4b7257a6a013/src/Aspire.Hosting/Dcp/ApplicationExecutor.cs#L579
Microsoft Reviewers: Open in CodeFlow