use resource name in metrics and traces page instead of instance id#2255
Merged
JamesNK merged 7 commits intomicrosoft:mainfrom Feb 17, 2024
Merged
Conversation
ghost
added
the
Member
|
There are a lot of subtleties to this problem and they're not all fixed here. I think it's probably best if this is merged as a starting point and I fixed linked naming issues in a follow up PR.
|
Member
Author
…id-params # Conflicts: # src/Aspire.Dashboard/Components/Pages/Metrics.razor.cs # src/Aspire.Dashboard/Components/Pages/Traces.razor.cs
JamesNK
approved these changes
Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use resource name as a more friendly name, so that we have one common method across all of the pages
Microsoft Reviewers: Open in CodeFlow