Skip to content

Improve trace span overflow#2302

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/fix-trace-overflow-2
Feb 20, 2024
Merged

Improve trace span overflow#2302
JamesNK merged 1 commit intomainfrom
jamesnk/fix-trace-overflow-2

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 19, 2024

  • Fix border around overflow count badge
  • Change overflow dialog to show full span badge

After:
image

Microsoft Reviewers: Open in CodeFlow

@($"+{another_name.ItemsOverflow.Count()}")
</span>
</MoreButtonTemplate>
<OverflowTemplate Context="another_name">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we use this weird name?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from a sample in one place and have then been using it everywhere. Will update it at some point.

@JamesNK JamesNK merged commit a054d86 into main Feb 20, 2024
@JamesNK JamesNK deleted the jamesnk/fix-trace-overflow-2 branch February 20, 2024 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants