[release/8.0-preview4] Optimize project templates#2473
Merged
joperezr merged 3 commits intorelease/8.0-preview4from Feb 28, 2024
Merged
[release/8.0-preview4] Optimize project templates#2473joperezr merged 3 commits intorelease/8.0-preview4from
joperezr merged 3 commits intorelease/8.0-preview4from
Conversation
ghost
added
the
area-codeflow
joperezr
reviewed
Feb 27, 2024
...e-starter/AspireStarterApplication.1.ApiService/AspireStarterApplication.1.ApiService.csproj
Show resolved
Hide resolved
joperezr
reviewed
Feb 27, 2024
.../aspire-empty/AspireApplication.1.ServiceDefaults/AspireApplication.1.ServiceDefaults.csproj
Show resolved
Hide resolved
joperezr
reviewed
Feb 27, 2024
src/Aspire.ProjectTemplates/templates/aspire-apphost/Properties/launchSettings.json
Show resolved
Hide resolved
joperezr
approved these changes
Feb 27, 2024
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
raised a couple of questions, but this looks good otherwise.
eerhardt
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2421 to release/8.0-preview4
/cc @eerhardt @Varorbc
Customer Impact
Our templates are referencing an older version of
OpenTelemetry.Instrumentation.Runtime. This PR in main updated the version, while also updating a few minor things to make the templates more inline with ASP.NET templates.Testing
Manually verified these code changes still allow the template apps to work.
Risk
Minor risk in using the new version of the NuGet package. But it would be good to know about any issues sooner.