Backport keyboard shortcut fixes into p4#2483
Merged
joperezr merged 4 commits intomicrosoft:release/8.0-preview4from Feb 27, 2024
Merged
Backport keyboard shortcut fixes into p4#2483joperezr merged 4 commits intomicrosoft:release/8.0-preview4from
joperezr merged 4 commits intomicrosoft:release/8.0-preview4from
Conversation
* Fix shortcuts changing multiple browser windows * Clean up (cherry picked from commit fcadd63)
…soft#2466) * Fix keyboard shortcuts and url casing * Suppress JSDisconnectedException * Check MetaKey and refactor modifier key checks --------- Co-authored-by: Adam Ratzman <adam@adamratzman.com> (cherry picked from commit 197c21e)
* Untrack DialogReference when dialog is closed * Fix keyboard shortcuts and url casing * Suppress JSDisconnectedException * Check MetaKey and refactor modifier key checks * removed redundant extra OnDialogCloseRequested call --------- Co-authored-by: Adam Ratzman <adam@adamratzman.com> Co-authored-by: Ratzman, Adam Mortimer <aratzman@iu.edu> (cherry picked from commit 0a7b6c7)
…nce in MainLayout (microsoft#2476) * Use OnDialogClosing instead of OnDialogResult * Remove redundant event listener --------- Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit 1434b99)
ghost
added
the
Member
|
@adamint can you list not only the issues this fixes but also the PRs to the main branch that this is grouping? I ask because we will later do an audit of changes to ensure that changes in release branch were done in main, and it helps getting the mapping |
kvenkatrajan
approved these changes
Feb 27, 2024
JamesNK
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a series of changes to fix various shortcut scenarios, as well as preventing a memory leak and avoiding blocking other browser shortcuts.
#2450
#2458
#2459
#2460
#2461
#2462
#2467
Microsoft Reviewers: Open in CodeFlow