Improve resource subscription performance and safety#2665
Merged
Conversation
e322595 to
e40d928
Compare
tlmii
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2496
The goal of these changes is to make the dashboard client update the UI at the interval it wants to (max 10 times a second) and not the interval that external data sources force upon it.
GetBatchesAsyncbecause the first write to the channel will trigger to reader. There is no write then flush.GetBatchesAsync. This puts a limit on how often data is returned. If the UI is updating frequently this will cause fewer, bigger updates. Prevent UI re-rendering too much.DashboardClient.SubscribeConsoleLogsto read from gRPC and write to a channel, then read from the channel in batches. Allows it to take advantage of improvement toGetBatchesAsync.Telemetry subscriptions will be in a separate PR. Telemetry subscriptions are different in that they use callbacks instead of async streams. The idea will be the same, limit callbacks to a min interval, but the implementation will be different.