Represent expressions made up of multiple properties of other resources.#2759
Merged
Represent expressions made up of multiple properties of other resources.#2759
Conversation
ghost
added
the
area-app-model
properties of other resources. - Re-implement GetConnectionString to use ReferenceExpressions - Centralize hard coding of host.docker.internal - Fixed tests - Added suport for reference expressions in environment variables.
davidfowl
force-pushed
the
davidfowl/expressions
branch
from
1cd06c0 to
b3e1f75
Compare
mitchdenny
approved these changes
Mar 10, 2024
Member
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
This reference abstraction is really coming together nicely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
ReferenceExpressionwhich uses string interpolation to represent expressions that reference multiple resources. This removes duplication between the manifest and runtime model and allows introspection of the reference parameters.GetConnectionString.GetConnectionStringAsyncto use ReferenceExpressionsContributes to #2639
Fixes #2428
Microsoft Reviewers: Open in CodeFlow