Refactor Directory.Packages.props#2791
Merged
eerhardt merged 2 commits intomicrosoft:mainfrom Mar 12, 2024
Merged
Conversation
ghost
added
the
area-integrations
ReubenBond
approved these changes
Mar 11, 2024
eerhardt
commented
Mar 11, 2024
|
|
||
| <ItemGroup> | ||
| <TextReplacementValue Include="MicrosoftDotnetSdkInternalPackageVersion" NewValue="$(MicrosoftDotnetSdkInternalPackageVersion)" /> | ||
| <TextReplacementValue Include="MicrosoftNETCoreAppRefPackageVersion" NewValue="$(MicrosoftNETCoreAppRefPackageVersion)" /> |
Member
Author
There was a problem hiding this comment.
FYI @joperezr - I searched the repo for these strings and couldn't find them being used anymore. So I removed them. If you know that they are still used, please let me know.
Member
There was a problem hiding this comment.
Yeah, they were used by our project that builds the manifest and does the replacements, but we have changed the template manifest and targets, so if it's not used in any of the .in. files here: https://github.com/dotnet/aspire/tree/main/src/Microsoft.NET.Sdk.Aspire it should be fine to remove.
Group dependencies (mostly) by the way they are used. For example, if a dependency is only used in tests, or playground apps, move them out of the same group where real product dependencies are listed. Also remove a couple unneeded PackageVersions.
eerhardt
force-pushed
the
FixupDependencies
branch
from
76f0359 to
cf4a61e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group dependencies (mostly) by the way they are used. For example, if a dependency is only used in tests, or playground apps, move them out of the same group where real product dependencies are listed.
Also remove a couple unneeded PackageVersions.
Microsoft Reviewers: Open in CodeFlow