Bring environment and arguments to parity#2797
Merged
Conversation
- Added IResourceWithArgs, and moved all of the WithArgs extension methods to it. - Allow objects in command line arguments. - Added tests
ghost
added
the
area-app-model
davidfowl
commented
Mar 12, 2024
|
|
||
| var manifest = await ManifestUtils.GetManifest(c2.Resource); | ||
|
|
||
| var expectedManifest = |
Contributor
Author
There was a problem hiding this comment.
@vhvb1989 in case azd doesn't support expressions in the argument list
Contributor
There was a problem hiding this comment.
Will take a look.
Thanks for the heads up.
- Removed args array from ExecutableResource and use WithArgs
davidfowl
added
the
breaking-change
mitchdenny
reviewed
Mar 12, 2024
| var value = arg switch | ||
| { | ||
| string s => s, | ||
| IValueProvider valueProvider => await GetValue(key: null, valueProvider, resourceLogger, isContainer: false, cancellationToken).ConfigureAwait(false), |
mitchdenny
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IResourceWithArgs, and moved all of the WithArgs extension methods to it.Microsoft Reviewers: Open in CodeFlow