[automated] Merge branch 'release/8.0-preview4' => 'main'#2853
Merged
joperezr merged 8 commits intomicrosoft:mainfrom Mar 13, 2024
Merged
Conversation
Co-authored-by: Brennan <brecon@microsoft.com>
* Fix shortcuts changing multiple browser windows (microsoft#2470) * Fix shortcuts changing multiple browser windows * Clean up (cherry picked from commit fcadd63) * Fix keyboard shortcuts, url casing and JSDisconnectedException (microsoft#2466) * Fix keyboard shortcuts and url casing * Suppress JSDisconnectedException * Check MetaKey and refactor modifier key checks --------- Co-authored-by: Adam Ratzman <adam@adamratzman.com> (cherry picked from commit 197c21e) * Untrack DialogReference when dialog is closed (microsoft#2465) * Untrack DialogReference when dialog is closed * Fix keyboard shortcuts and url casing * Suppress JSDisconnectedException * Check MetaKey and refactor modifier key checks * removed redundant extra OnDialogCloseRequested call --------- Co-authored-by: Adam Ratzman <adam@adamratzman.com> Co-authored-by: Ratzman, Adam Mortimer <aratzman@iu.edu> (cherry picked from commit 0a7b6c7) * Use OnDialogClosing instead of OnDialogResult to remove dialog reference in MainLayout (microsoft#2476) * Use OnDialogClosing instead of OnDialogResult * Remove redundant event listener --------- Co-authored-by: Adam Ratzman <adamratzman@microsoft.com> (cherry picked from commit 1434b99) --------- Co-authored-by: James Newton-King <james@newtonking.com> Co-authored-by: Tim Mulholland <tlmii@users.noreply.github.com>
* Use https * Remove default properties * update otel package version --------- Co-authored-by: Varorbc <varorbc@gmail.com>
Co-authored-by: Ratzman, Adam Mortimer <aratzman@iu.edu>
* Isolate the use of docker.host.internal - For podman support we need to use another host name (host.containers.internal). That's configurable using a setting AppHost:ContainerHostName. Remove the hardcoded use of docker.host.internal and instead read from configuration everywhere. * Fixed nit
joperezr
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I detected changes in the release/8.0-preview4 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.
This PR merges commits made on release/8.0-preview4 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/8.0-preview4-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.
Microsoft Reviewers: Open in CodeFlow