Merged
Conversation
eerhardt
commented
Mar 15, 2024
| /// <param name="resource">The resource to add.</param> | ||
| /// <returns>A builder for configuring the added resource.</returns> | ||
| /// TODO eerhardt DistributedApplicationExceptionThrown when a resource with the same name already exists. | ||
| /// <exception cref="DistributedApplicationException">Thrown when a resource with the same name already exists.</exception> |
davidfowl
approved these changes
Mar 15, 2024
Contributor
|
Well this might multi-target later |
Member
Author
Yeah, my thinking is that ServiceDiscovery can solve the multi-targeting at that time. |
It is not necessary on net8.0.
22b07bd to
fcb99de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not necessary on net8.0.
Microsoft Reviewers: Open in CodeFlow