Skip to content

Remove ValueStopwatch#2935

Merged
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:RemoveValuesStopWatch
Mar 18, 2024
Merged

Remove ValueStopwatch#2935
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:RemoveValuesStopWatch

Conversation

@eerhardt
Copy link
Copy Markdown
Member

@eerhardt eerhardt commented Mar 15, 2024

It is not necessary on net8.0.

Microsoft Reviewers: Open in CodeFlow

/// <param name="resource">The resource to add.</param>
/// <returns>A builder for configuring the added resource.</returns>
/// TODO eerhardt DistributedApplicationExceptionThrown when a resource with the same name already exists.
/// <exception cref="DistributedApplicationException">Thrown when a resource with the same name already exists.</exception>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing a mistake in #2933

@davidfowl
Copy link
Copy Markdown
Contributor

Well this might multi-target later

@eerhardt
Copy link
Copy Markdown
Member Author

Well this might multi-target later

Yeah, my thinking is that ServiceDiscovery can solve the multi-targeting at that time.

It is not necessary on net8.0.
@eerhardt eerhardt force-pushed the RemoveValuesStopWatch branch from 22b07bd to fcb99de Compare March 18, 2024 14:47
@eerhardt eerhardt enabled auto-merge (squash) March 18, 2024 14:48
@eerhardt eerhardt merged commit 16c0bb2 into microsoft:main Mar 18, 2024
@eerhardt eerhardt deleted the RemoveValuesStopWatch branch March 18, 2024 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants