Skip to content

Fix for invalid parameter names.#2949

Merged
mitchdenny merged 5 commits intomainfrom
midenn/fix-2783
Mar 18, 2024
Merged

Fix for invalid parameter names.#2949
mitchdenny merged 5 commits intomainfrom
midenn/fix-2783

Conversation

@mitchdenny
Copy link
Copy Markdown
Member

@mitchdenny mitchdenny commented Mar 16, 2024

Fixes #2783

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 16, 2024
@mitchdenny mitchdenny self-assigned this Mar 16, 2024
@mitchdenny mitchdenny added this to the preview 5 (Apr) milestone Mar 16, 2024
@davidfowl
Copy link
Copy Markdown
Contributor

This doesn't cover setting the values directly into the dictionary.

@mitchdenny
Copy link
Copy Markdown
Member Author

mitchdenny commented Mar 16, 2024

No, it doesn't. We would need to either sub-class Dictionary<K, T> for that or perhaps add the following methods to the class and not expose the underlying dictionary. We'd need SetParameter(...), GetParameter(key) and GetParameters().

@mitchdenny mitchdenny requested a review from danmoseley March 18, 2024 01:08
@mitchdenny mitchdenny merged commit e4d9175 into main Mar 18, 2024
@mitchdenny mitchdenny deleted the midenn/fix-2783 branch March 18, 2024 03:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not allow - for builder.AddBicepTemplate().WithParameter() function.

4 participants