Defer instrumentation of Redis connection#2982
Merged
DamianEdwards merged 7 commits intomainfrom Mar 19, 2024
Merged
Conversation
ghost
added
the
area-integrations
davidfowl
reviewed
Mar 18, 2024
src/Components/Aspire.StackExchange.Redis/AspireRedisExtensions.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Mar 18, 2024
src/Components/Aspire.StackExchange.Redis/AspireRedisExtensions.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
The test failure is odd. I looked through it with @davidfowl and it appeared more like a race condition somewhere in our test code or OpenTelemetry itself and I haven't been able to repro it locally (logged #2987). Open to other ideas. |
eerhardt
reviewed
Mar 18, 2024
eerhardt
reviewed
Mar 19, 2024
src/Components/Aspire.StackExchange.Redis/AspireRedisExtensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Mar 19, 2024
src/Components/Aspire.StackExchange.Redis/AspireRedisExtensions.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Mar 19, 2024
eerhardt
reviewed
Mar 19, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Tests that register an ActivityListener need to run in a separate process so they don't get Activities from other tests. - ActivityNotifier needs to run its Task continuations asynchronously, or tests can deadlock when continuing on the "drain" background thread. Also remove dead code.
DamianEdwards
force-pushed
the
damianedwards/defer-redis-tracing
branch
from
318cd40 to
a31b40f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2907
Microsoft Reviewers: Open in CodeFlow